Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting up gpg keys link to SIGNING_SECRET_KEY #101

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 24, 2021

Q A
Documentation yes
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Adds a link to how to setup gpg to secrets table.

This allows getting straight to the point without having to panic and being uncertain how to perform a specific task.

Adds a link to how to setup gpg to secrets table

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@Ocramius Ocramius added this to the 1.9.2 milestone Jan 24, 2021
@Ocramius Ocramius self-assigned this Jan 24, 2021
@Ocramius Ocramius merged commit d4556b6 into laminas:1.9.x Jan 24, 2021
@Ocramius
Copy link
Member

Thanks!

@glensc
Copy link
Contributor Author

glensc commented Jan 24, 2021

This was a close hit! :)

You merged without waiting for CI to pass, but I had not signed DCO and the anchor link missed a #

NOTE to self: always start with a Draft, even if it's a trivial change, especially if it's a trivial change.

@glensc glensc deleted the patch-3 branch January 24, 2021 22:11
@Ocramius
Copy link
Member

@glensc I don't really care that much about DCO unless it's a major feature. Indeed, I thought it was pointing to a file though :-\

@glensc
Copy link
Contributor Author

glensc commented Jan 24, 2021

@Ocramius but I managed to fix before merge, the correct commit was merged :)

@Ocramius
Copy link
Member

Yeh, saw the push 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants