Reduce docker image size (and build time) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This swaps the base image so that we can have: * faster builds * smaller images * more secure and up-to-date dependencies Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
It's recommended to use `COPY` instead of `ADD` because it's much simpler and avoids unexpected behaviour - `ADD` can also do things like uncompressing files and remote requests. More info: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
|
We can compare the speed improvements on the build too: a previous run took 1m31s while this one took 41s. |
|
I just noticed that we don't have the branch |
Ocramius
approved these changes
Feb 24, 2021
Slamdunk
reviewed
Feb 25, 2021
glensc
approved these changes
Feb 25, 2021
We only need to dump the autoloader at this stage, so it's unnecessary to do anything beyond that. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
BuildKit is an optimised builder for docker. Although it isn't enabled by default, it helps to speed up the process even more and it's quite stable at this point. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
reduce-image-size
branch
from
3aba155
to
144704b
Compare
Ocramius
reviewed
Feb 25, 2021
| @@ -18,4 +18,4 @@ jobs: | |||
| uses: "actions/checkout@v2" | |||
|
|
|||
| - name: "Docker Build" | |||
| run: "docker build ." | |||
| run: "DOCKER_BUILDKIT=1 docker build ." | |||
|
Branching fixed: 🚢 |
|
Thanks @Ocramius |
|
I CANNOT WAIT for my next release to see the speed improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the build process of the docker image.
When the base images are already downloaded, it takes about 15s to build the image using BuildKit - previously it was taking 1m19s.
The image size has also been drastically reduced, it's 122Mb - previously was 390Mb.