replace thecodingmachine/safe, webmozart/assert, and symfony/process by azjezz/psl

[azjezz]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	no

Description

Similar to Roave/BackwardCompatibilityCheck#306, this PR replaces thecodingmachine/safe, webmozart/assert, and symfony/process by azjezz/psl.

This reduces the amount of dependencies, and relies on a better type assertion component provided by PSL.

Psl also ships with functions that replace PHP builtin to provide a better error handling, and consistency.

symfony/process is not made absolute by Psl\Shell\execute, as execute function is created as a replacement for exec builtin function, however, it provides enough functionality ( working directory, argument escaping, environment variables .. etc ) to replace the usage of symfony/process within this library ( if more features are needed later on, it makes sense to bring symfony/process back ).

[froschdesign]

@azjezz

This reduces the amount of dependencies…

The number of dependent libraries is reduced, but the dependency to one library is increased. Because function calls that were previously based on classic PHP are replaced.
Therefore, I think that this argument does not work here.

(My statement refers only to this one argument and does not make any technical assessment!)

[azjezz]

The number of dependent libraries is reduced, but the dependency to one library is increased

Yes, but that's -3 vs +1. so we are still down 2.

Because function calls that were previously based on classic PHP are replaced.

see Roave/BackwardCompatibilityCheck#306 (comment) and Roave/BackwardCompatibilityCheck#306 (comment) on why builtin functions were replaced.

[froschdesign]

@azjezz

…on why builtin functions were replaced.

Again: I have not made any technical assessment of the individual functions, I have only said that by replacing classical functions, the dependence to one library is increased. That is not a criticism or evaluation on Str\format or Str\trim_right itself!
And for that reason, the argument doesn't work for me – and I only mean this one argument!

[Ocramius]

Stellar improvement! Very happy with the changes so far, so the comments are mostly about small details, and some type-related issues in the test suite.

[Ocramius]

Excellent refactoring, thanks!

[bendavies]

@azjezz why not Type\non_empty_string()->matches($value) here?

[azjezz]

we, you can do that too, same thing

[bendavies]

it doesn't work actually, I found.

ERROR: MoreSpecificReturnType - The declared return type 'non-empty-string' for EnvironmentVariables::getenv is more specific than the inferred return type 'string' (see https://psalm.dev/070)

ERROR: LessSpecificReturnStatement -- The type 'string' is more general than the declared return type 'non-empty-string' for EnvironmentVariables::getenv (see https://psalm.dev/129)

[bendavies]

ah, yes it does. i was trying

Psl\invariant(
    Type\non_empty_string()->assert($value),
    Str\format('Could not find a value for environment variable "%s"', $key)
);

instead of just

Type\non_empty_string()->assert($value);

but i guess you then lose the custom invariant error message.

[azjezz]

yea, you lose the message with assert, maybe we could add a costume message as a second argument, not sure 🤔

[bendavies]

Sounds good!