Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private repository release support #140

Merged
merged 4 commits into from
May 23, 2021

Conversation

Lansoweb
Copy link
Contributor

@Lansoweb Lansoweb commented May 22, 2021

Fixing #139 to allow usage on private repositories.

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #139

Signed-off-by: Leandro Silva <leandro.silva@zooxsmart.com>
Signed-off-by: Leandro Silva <leandro.silva@zooxsmart.com>
@Ocramius Ocramius changed the title Private repository Private repository release support May 22, 2021
@Ocramius Ocramius self-assigned this May 22, 2021
@Ocramius Ocramius added the Bug Something isn't working label May 22, 2021
@Ocramius Ocramius added this to the 1.12.1 milestone May 22, 2021
Signed-off-by: Leandro Silva <leandro.silva@zooxsmart.com>
Signed-off-by: Leandro Silva <leandro.silva@zooxsmart.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even considering test issues discussed.

Will tag a release immediately :-)

@Ocramius Ocramius merged commit 765fadf into laminas:1.12.x May 23, 2021
@Lansoweb Lansoweb deleted the private-repository branch May 23, 2021 18:31
@Lansoweb
Copy link
Contributor Author

Thanks a lot! It's working now :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants