Use git config credential.helper 'store --file=/tmp/file' for git push`
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ush` This should fix some underlying design issues described in #198 The full URI of the repository, which includes a token in plaintext, is now no longer the actual `git remote` URI, and is instead stored in a temporary file which `git` uses to authenticate with the remote. This prevents the remote URI from leaking in `STDOUT`/`STDERR`, which are visible in case of crashes.
…xfiltate those credentials This test fails on `1.14.x`, and succeeds on `HEAD`, therefore validating the current patch, and preventing a security regression.
Ocramius
commented
Jul 26, 2022
test/unit/Git/FetchAndSetCurrentUserByReplacingCurrentOriginRemoteTest.php
Show resolved
Hide resolved
Ocramius
deleted the
fix/#198-use-git-internal-credential-store-for-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some underlying design issues described in #198
The full URI of the repository, which includes a token in plaintext, is now no
longer the actual
git remoteURI, and is instead stored in a temporaryfile which
gituses to authenticate with the remote.This prevents the remote URI from leaking in
STDOUT/STDERR, which arevisible in case of crashes.
This is a partial fix of #198 - the issue with
gitbeing broken upfront is still there.