Log error response message

[ghostwriter]

• If GitHub responds with a status code >= 200 && <= 299 the application will return the html_url for the release.
• Otherwise, the application checks for message field describing the error

[Ocramius]

Infection CI failures unrelated: seems to be a regression from #220 which somehow didn't trip during PR phase 🤷

[Ocramius]

🚢 here meanwhile

[Ocramius]

Urgh, wait, no - I was bamboozled by CTRL+F not working in github logs 🤦

9) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] Concat

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation(PHP_EOL . 'Failed to create release through GitHub API;' . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
 }


10) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] ConcatOperandRemoval

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation(PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . PHP_EOL . 'Status code: %s' . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
 }


15) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] ConcatOperandRemoval

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
 }


16) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] Concat

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . 'Message: %s' . PHP_EOL . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
 }


17) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] ConcatOperandRemoval

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . PHP_EOL, $statusCode, $errorResponseData['message']);
     }
 }


18) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] Concat

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . PHP_EOL . 'Message: %s', $statusCode, $errorResponseData['message']);
     }
 }


19) /github/workspace/src/Github/Api/V3/CreateReleaseThroughApiCall.php:74    [M] ConcatOperandRemoval

--- Original
+++ New
@@ @@
             return new Uri($responseData['html_url']);
         }
         $errorResponseData = typed($responseBody, shape(['message' => non_empty_string()]));
-        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s' . PHP_EOL, $statusCode, $errorResponseData['message']);
+        invariant_violation('Failed to create release through GitHub API;' . PHP_EOL . 'Status code: %s' . PHP_EOL . 'Message: %s', $statusCode, $errorResponseData['message']);
     }
 }

In practice, my reccomendation:

• remove most concatenations, especially no need for PHP_EOL
• make sure that code path is covered - seems to really not be hit

[ghostwriter]

The code path is covered, infection doesn’t recognize it was recently fixed sebastianbergmann/php-code-coverage#969 but not yet released.

Correct me if I'm wrong, If infection recognized Throw_ mutants correctly, it would recognize that all of the Concat* mutants would cause this test to fail because it assert that we got a specific exception message.

[Ocramius]

I can also wait for sebastianbergmann/php-code-coverage#969

Doing the same for Roave/BetterReflection#1320

[ghostwriter]

Sounds good to me.

[Ocramius]

The reason why this was failing is that list<> contains an "empty" list type too.

As suggested, this can be iterable<int, array{array<string, mixed>}>`, which enforces the existence of the first array key inside each data provider entry 👍

[Ocramius]

Thanks @ghostwriter!