Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env-specific tests #225

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Fix env-specific tests #225

merged 1 commit into from
Dec 18, 2022

Conversation

ghostwriter
Copy link
Contributor

@ghostwriter ghostwriter commented Dec 18, 2022 •
edited by Ocramius
Loading

Fixes #224

@ghostwriter
Fix env-specific tests
aa7dacd 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the base branch from 1.21.x to 1.20.x December 18, 2022 14:25
@Ocramius Ocramius added the Bug Something isn't working label Dec 18, 2022
@Ocramius Ocramius added this to the 1.20.1 milestone Dec 18, 2022
Ocramius
Ocramius approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ghostwriter!

@Ocramius Ocramius self-assigned this Dec 18, 2022
@Ocramius Ocramius merged commit e7321df into laminas:1.20.x Dec 18, 2022
@Ocramius Ocramius mentioned this pull request Dec 18, 2022
Closed
@github-actions github-actions bot mentioned this pull request Dec 18, 2022
Merged
@ghostwriter ghostwriter deleted the bugfix/failing-env-specific-tests-224 branch December 18, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.20.1
Development

Successfully merging this pull request may close these issues.

Env-specific tests fail depending on random execution order
2 participants
@ghostwriter @Ocramius