Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fixes #247

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Ci fixes #247

merged 7 commits into from
Sep 13, 2023

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Sep 13, 2023

Q A
QA yes

Description

CI is failing in various ways because of some trivial problems…

  • Fix linting issues with README.md
  • Bump all deps and prevent composer installation problems by denying the php-http/discovery composer plugin
  • Fix deprecations in PHPUnit and php-http/discovery

@gsteel
Fix markdownlint issues with README.md
56a6ab9 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Bump all dependencies. Deny the http-discovery composer plugin
cfa5210 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Replace call to deprecated HttpClientDiscovery::find()
aae1aab 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Work around deprecation of MockObject::withConsecutive()
c6cf375 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 1.25.0 milestone Sep 13, 2023
@gsteel
Remove unused use
3097404 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Fix some escaped mutants around response code expectations
5e087d7 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Copy link
Member Author

gsteel commented Sep 13, 2023

@Ocramius any ideas on improving MSI here? Most of the mutants are escaping via calls to Shell\Execute and it's not like that can be mocked 🤷‍♂️

@gsteel
Adjust minMsi and minCoveredMsi
3c72cfe 
Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius Ocramius self-assigned this Sep 13, 2023
@Ocramius Ocramius added Enhancement dependencies Pull requests that update a dependency file labels Sep 13, 2023
Ocramius
Ocramius approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsteel!

@Ocramius Ocramius merged commit aa2ce05 into laminas:1.25.x Sep 13, 2023
10 checks passed
@gsteel gsteel deleted the ci-fixes branch September 13, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @Ocramius