Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new milestones automatically #37

Merged
merged 17 commits into from
Aug 31, 2020
Merged

Create new milestones automatically #37

merged 17 commits into from
Aug 31, 2020

Conversation

geerteltink
Copy link
Member

Q A
New Feature yes

Description

Create next milestones after a release is prepared.

Closes #26

@geerteltink geerteltink marked this pull request as draft August 10, 2020 18:12
Ocramius
Ocramius requested changes Aug 11, 2020
View reviewed changes
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Github/Api/V3/CreateMilestoneThroughApiCall.php Outdated Show resolved Hide resolved
@Ocramius Ocramius added this to the 1.3.0 milestone Aug 11, 2020
@Ocramius Ocramius modified the milestones: 1.3.0, 1.2.0 Aug 11, 2020
@Ocramius Ocramius modified the milestones: 1.2.0, 1.3.0 Aug 12, 2020
@weierophinney weierophinney modified the milestones: 1.3.0, 1.4.0 Aug 26, 2020
@geerteltink @weierophinney
Create new milestones
0271e46 
Signed-off-by: Geert Eltink <dev@elt.ink>
@weierophinney weierophinney changed the base branch from 1.2.x to 1.4.x August 26, 2020 19:56
@geerteltink
Add logging for milestone creation
652b820 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Improve mile stone failed detection
b92e8d5 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Fix milestone request body
d62f5c3 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Fix next milestone generation
019e0e8 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Use logger instead of command output
c1d9b8a 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Fix coding style
65ca749 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Inject logger to create milestones command
2019f66 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Add milestone creation tests
1e59282 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink geerteltink marked this pull request as ready for review August 30, 2020 19:32
@geerteltink
Add milestone creation to the github workflow
92272a3 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Fix coding styles
1f64fad 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Copy link
Member Author

@Ocramius ready for final review. The test repo I used is here: https://github.com/xtreamwayz/refactored-stroopwafel/milestones. All milestones there are automatically created.

Ocramius
Ocramius requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed. Overall OK with adding this as a new step (although perhaps earlier in the release workflow?)

We kinda need to simplify the setup for end users though, so that they don't need to change their configuration all the time (new ticket, perhaps?)

.github/workflows/automatic-release.yml Show resolved Hide resolved
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
examples/.github/workflows/release-on-milestone-closed-triggering-release-event.yml Outdated Show resolved Hide resolved
examples/.github/workflows/release-on-milestone-closed.yml Outdated Show resolved Hide resolved
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Github/Api/V3/CreateMilestone.php Outdated Show resolved Hide resolved
weierophinney
weierophinney requested changes Aug 31, 2020
View reviewed changes
.github/workflows/automatic-release.yml Show resolved Hide resolved
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Application/Command/CreateMilestones.php Outdated Show resolved Hide resolved
src/Github/Api/V3/CreateMilestoneThroughApiCall.php
Comment on lines +62 to +64
->withAddedHeader('Content-Type', 'application/json')
->withAddedHeader('User-Agent', 'Ocramius\'s minimal API V3 client')
->withAddedHeader('Authorization', 'token ' . $this->apiToken);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this patch, but perhaps we should have a specialized PSR-17 request factory that adds these headers to the request generated by the factory? Thoughts, @Ocramius ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weierophinney I don't think this is the responsibility of the factory, but rather of a Github API client: the fact that a token is added, and that a user-agent is added, is specific to Github's requirements, and we can decorate the request there if needed.

I would keep it as-is unless we keep adding more and more Github API interactions.

test/unit/Git/Value/SemVerVersionTest.php Show resolved Hide resolved
test/unit/Git/Value/SemVerVersionTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreateMilestoneTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreateMilestoneTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreateMilestoneTest.php Outdated Show resolved Hide resolved
@geerteltink
Use the standard github token for creating milestones
bbaeebf 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Fix milestone creation review issues
bd40e5a 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Indent nowdoc strings
64ec045 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Apply coding style formatting
5d3988e 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
More psalm annotations
4b528e1 
Signed-off-by: Geert Eltink <dev@elt.ink>
Ocramius
Ocramius approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Ocramius Ocramius changed the title Create new milestones Create new milestones automatically Aug 31, 2020
@geerteltink
Copy link
Member Author

Running some final tests now.

@Ocramius
Copy link
Member

@geerteltink ping me and I'll get 1.4.0 through tonight, if all worked :-)

weierophinney
weierophinney requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks only, but looks good!

test/unit/Github/Api/V3/CreateMilestoneTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreateMilestoneTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreatePullRequestTest.php Outdated Show resolved Hide resolved
test/unit/Github/Api/V3/CreateReleaseTest.php Outdated Show resolved Hide resolved
@geerteltink
Cosmetic tweaks
c95c11b 
Signed-off-by: Geert Eltink <dev@elt.ink>
@geerteltink
Copy link
Member Author

@Ocramius 🚢

weierophinney
weierophinney approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well, I can understand what is happening! Nice work, @geerteltink !

@Ocramius Ocramius merged commit c95ea93 into laminas:1.4.x Aug 31, 2020
@Ocramius Ocramius self-assigned this Aug 31, 2020
@geerteltink geerteltink deleted the feat/milestones branch August 31, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@weierophinney weierophinney weierophinney approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Create next milestones after a release is prepared
3 participants
@geerteltink @Ocramius @weierophinney