Strip empty sections from keep-a-changelog release notes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only looking for and removing "default contents" (i.e., what is generated via keep-a-changelog `bump*` operations), this patch looks for any of the default sections that have the "- Nothing" default contents and removes them. Fixes laminas#63 Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Ocramius
approved these changes
Sep 3, 2020
|
@michalbundyra There will still be some redundancy between stuff in the main changelog and the generated contents, but the former will give user-focused context that the latter does not. What this patch does, however, is remove the verbosity of that "Nothing" boilerplate, which should make this look better. The fixes for #64 address the rest of it, which is redundancy in headings and whatnot introduced by the release notes generator. The combination of the the two should give us something you're more comfortable with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only looking for and removing "default contents" (i.e., what is generated via keep-a-changelog
bump*operations), this patch looks for any of the default sections that have the- Nothingdefault contents and removes them.Fixes #63