Sign commits, as well as tags #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
approved these changes
Sep 5, 2020
Ocramius
requested changes
Sep 5, 2020
| @@ -93,6 +106,12 @@ public function testFailsIfNotOnCorrectBranch(): void | |||
| $this->expectException(InvalidArgumentException::class); | |||
| $this->expectExceptionMessage('different branch'); | |||
| (new CommitFileViaConsole()) | |||
| ->__invoke($this->checkout, BranchName::fromName('1.0.x'), 'README.md', 'commit message'); | |||
| ->__invoke( | |||
There was a problem hiding this comment.
I think we meed a test that verifies that the commit is signed
Signed-off-by: Ben Ramsey <ben@benramsey.com>
Ocramius
changed the title
|
FWIW, not a BC break, since this is an application, not a library 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, automatic-releases signs Git tags using the signing key but not commits. This PR provides support for signing commits, as well.
This is a BC break because some of the interfaces have changed to require
Laminas\AutomaticReleases\Gpg\SecretKeyId. This is not an optional parameter. As such, this change might need to wait until 2.0.0, unless the risk is deemed acceptable for 1.7.0 or 1.8.0.