Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply component changes during update #28

Merged
merged 1 commit into from
Apr 30, 2021
Merged

feat: apply component changes during update #28

merged 1 commit into from
Apr 30, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Apr 7, 2021

Q A
BC Break no
New Feature yes

Description

This feature will introduce a diff between two package versions.
The Idea is likely described in #10:

  1. Every UpdateOperation from composer has a previous package and the new package
  2. Compare the previous and the new package "extra" section (from composer.json)
  3. If the previous version had an entry for the component installer and the new one does not, laminas support was probably removed from that version and we are triggering the remove logic
  4. If the previous version did not contain component installer extra section but the new one does, laminas support was probably added to that version and we are triggering the add logic

fixes #10

@boesing boesing mentioned this pull request Apr 7, 2021
Closed
@boesing
feat: apply component changes during update
1775fe8 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing force-pushed the feature/install-component-on-update branch from d670ef7 to 1775fe8 Compare April 30, 2021 19:45
weierophinney
weierophinney approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried this was going to be crazy-complex, but I actually understand it fine — nice work! 🚢

@weierophinney weierophinney added this to the 2.5.0 milestone Apr 30, 2021
@boesing boesing merged commit edc5048 into laminas:2.5.x Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weierophinney weierophinney weierophinney approved these changes

@geerteltink geerteltink Awaiting requested review from geerteltink

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Add ConfigProvider or Module when upgrading package
2 participants
@boesing @weierophinney