Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Renovate with reusable workflows #45

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Prepare for Renovate with reusable workflows #45

merged 6 commits into from
Mar 22, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@Ocramius Ocramius added this to the 2.7.0 milestone Feb 24, 2022
@Ocramius
Copy link
Member

CI seems to be broken here

@weierophinney
Copy link
Member

Looks like the Composer API changed? All "latest dependencies" runs are failing, and they appear to be issues with inheritance/type trees.

@Ocramius
Copy link
Member

@ghostwriter this needs a rebase - should be green afterwards.

@Ocramius Ocramius removed this from the 2.7.0 milestone Mar 22, 2022
@Ocramius Ocramius changed the base branch from 2.7.x to 2.8.x March 22, 2022 14:30
@Ocramius Ocramius added this to the 2.8.0 milestone Mar 22, 2022
@boesing
Copy link
Member

boesing commented Mar 22, 2022

Probably fixed the failing tests in #46
Thats really annoying when composer requires interfaces and then checks for specific implementations somewhere nested in their code.

Luckily, due to renovate, new releases from composer will be bumped here so we will get early feedback when something starts to break.

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Copy link
Contributor Author

ghostwriter commented Mar 22, 2022

Should I bump composer/composer to ^2.3.0-RC2?

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need: composer/composer is already checked out at 2.3.0-RC2 in the upper boundaries CI jobs :)

Thanks @ghostwriter!

@Ocramius Ocramius self-assigned this Mar 22, 2022
@Ocramius Ocramius merged commit 2f0ea6c into laminas:2.8.x Mar 22, 2022
@ghostwriter ghostwriter deleted the feature/renovate branch March 22, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants