Update to support PHP 8.0 #6
Conversation
- Adds `~8.0.0` to PHP constraint - Makes minimum supported PHP version 7.3 - Updates PHPUnit version to 9.3, php-mock-phpunit to 2.0, and vfsStream to 1.6.7 - Updates phpunit.xml.dist to 9.3 schema - Updates unit tests to work with PHPUnit 9.3 - Removes all prophecy usage in favor of phpunit mock objects Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
force-pushed
the
feature/php-8-support
branch
from
be713d3 to
1bd4706
Compare
| "new": "content" | ||
| } | ||
| EOC; |
There was a problem hiding this comment.
PHP 7.3 indented now/heredocs FTW!
| ->writeLine(Argument::containingString('Autoloading rules already exist for the module "App"')) | ||
| ->shouldBeCalled(); | ||
| $this->assertNotHelpOutput(STDERR); | ||
| ->expects($this->once()) | ||
| ->method('writeLine') | ||
| ->with('Autoloading rules already exist for the module "App"'); |
There was a problem hiding this comment.
This and other methods where I remove the call to either assertNotHelpOutput() or assertHelpOutput() were cases where I hit a serialization bug in PHPUnit that exists due to how mock object constraints are created. Most of these have a closure memoized internally, and these cannot be serialized, which raises an error. The only way I could get tests to run for these was to:
- Assert an exact number of invocations.
- Use exact expectations for arguments (vs using a constraint method like
stringContains()).
Since I'm now asserting that writeLine() is called an exact number of times, I know that the help output is NOT being created, allowing me to remove that assertion (and that assertion, because it essentially required a stringContains() comparison to be readable, was causing the seriailzation error).
~8.0.0to PHP constraint