Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brick/varexporter 0.5.0 #45

Merged
merged 1 commit into from
May 12, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented May 10, 2024

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

This PR adds support for brick/varexporter v0.5.0, which in turn supports nikic/PHP-Parser 5, enabling upgrades to PHPUnit 11 in downstream projects.

@acelaya acelaya force-pushed the varexporter-0.5 branch from e873ee2 to 0a48c8e Compare May 10, 2024 20:11
@@ -27,7 +27,7 @@
"extra": {},
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"brick/varexporter": "^0.4.0",
"brick/varexporter": "^0.5.0 || ^0.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.lock requires hashing again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my mistake. Should be done now.

Signed-off-by: Alejandro Celaya <alejandrocelaya@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ocramius Ocramius merged commit 9b79649 into laminas:1.15.x May 12, 2024
12 checks passed
@Ocramius Ocramius added this to the 1.15.0 milestone May 12, 2024
@snapshotpl
Copy link
Member

@acelaya @Ocramius here is same problem like with laminas/laminas-servicemanager#237

- Downloading brick/varexporter (0.4.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants