Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.14.x fix uniqid in test #223

Open
wants to merge 1 commit into
base: 2.19.x
Choose a base branch
from

Conversation

ZVanoZ
Copy link
Contributor

@ZVanoZ ZVanoZ commented Sep 28, 2021

Sometime, "uniqid" return value, similar to number.
It is give test error.

2021-09-26T13:19:58.1542106Z There was 1 failure:
2021-09-26T13:19:58.1542418Z 
2021-09-26T13:19:58.1543774Z 1) LaminasTest\Db\Sql\AbstractSqlTest::testProcessExpressionWorksWithNamedParameterPrefix
2021-09-26T13:19:58.1546087Z Failed asserting that 61507378202901 is identical to '61507378202901'.
2021-09-26T13:19:58.1546525Z 
2021-09-26T13:19:58.1558191Z ##[error]/github/workspace/test/unit/Sql/AbstractSqlTest.php:154

Forum
Bug appears

This pull request fixed the error and added test for check numeric prefix error.

@ZVanoZ ZVanoZ mentioned this pull request Sep 28, 2021
@ZVanoZ
Copy link
Contributor Author

ZVanoZ commented Sep 28, 2021

Whats wrong?
This seems to be a bug in the test system again.

--

There was 1 failure:

1) LaminasIntegrationTest\Db\Adapter\Driver\Pdo\Mysql\AdapterTest::testDriverDisconnectAfterQuoteWithPlatform
Failed asserting that true is false.

Error: /github/workspace/test/integration/Adapter/Driver/Pdo/AbstractAdapterTest.php:41

--
// test/integration/Adapter/Driver/Pdo/AbstractAdapterTest.php
    public function testDriverDisconnectAfterQuoteWithPlatform()
    {
        $isTcpConnection = $this->isTcpConnection();

        $this->adapter->getDriver()->getConnection()->connect();

        self::assertTrue($this->adapter->getDriver()->getConnection()->isConnected());
        if ($isTcpConnection) {
            self::assertTrue($this->isConnectedTcp());
        }

        $this->adapter->getDriver()->getConnection()->disconnect();

        self::assertFalse($this->adapter->getDriver()->getConnection()->isConnected());
        if ($isTcpConnection) {
            self::assertFalse($this->isConnectedTcp()); // LINE 41
        }
//...

…efix give an error.

Signed-off-by: ZVanoZ <edu.ZVanoZ@gmail.com>
@Xerkus Xerkus changed the base branch from 2.14.x to 2.19.x February 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant