Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #240 - reverted bump of laminas/laminas-coding-standard to ^2.3.0 #242

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

Ocramius
Copy link
Member

Reverts #240
Fixes #241

/cc @ghostwriter @arueckauer

@Ocramius Ocramius added the Bug Something isn't working label Mar 30, 2022
@Ocramius Ocramius added this to the 2.14.1 milestone Mar 30, 2022
@Ocramius Ocramius self-assigned this Mar 30, 2022
@Ocramius
Copy link
Member Author

7.3 + latest still fails, but better than a completely broken system:

FAILURES!
Tests: 1230, Assertions: 2077, Failures: 1, Warnings: 8, Skipped: 41, Incomplete: 80, Risky: 58.

@Ocramius Ocramius merged commit 7daba11 into 2.14.x Mar 30, 2022
@Ocramius Ocramius deleted the revert-240-feature/bump-laminas-coding-standard branch March 30, 2022 07:37
@arueckauer
Copy link
Member

Did not expect it to fail that bad. Thanks for both of your efforts!

@Ocramius
Copy link
Member Author

@arueckauer heh, green CI on this was very unexpected anyway :D

@ghostwriter
Copy link
Contributor

Why revert, instead of fixing the Types of the 2nd and 3rd arguments of var_export and str_replace respectively?

When a “feature” is released, and caused an undesired outcome in production; how do you fix the issue?

fix the issue in a minor patch

Create a separate bugfix branch with the fix

revert the feature

What do you do here?

Re-open the feature PR, fix the issue, re-merge?

Create a new feature Pr with code from feature branch with the additional bugfix commits?

I want to learn and understand the thought process behind the decisions so I can apply them correctly.

Thank you for you time.

@Ocramius
Copy link
Member Author

The question is also timing: I didn't have time to investigate nor fix this, so a full revert was quick and viable.

Re-applying the patch is possible afterwards, in 2.15.x or later, but for now, allowing usage of 2.14.1 takes priority.

@dstockto
Copy link

dstockto commented Apr 5, 2022

We ran into an issue w/ 2.14.0 as well - using non-strings (like ints) as literal column values mapped to a column name also caused a type error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants