Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support php 7, add php 8.2 support #259

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Drop support php 7, add php 8.2 support #259

merged 1 commit into from
Nov 18, 2022

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Oct 16, 2022

No description provided.

@Ocramius Ocramius added this to the 2.16.0 milestone Oct 16, 2022
@fezfez
Copy link
Contributor Author

fezfez commented Oct 16, 2022

@Ocramius php8.2-sqlsrv is apparently not ready

@Ocramius
Copy link
Member

Will likely take another while too..

@fezfez
Copy link
Contributor Author

fezfez commented Oct 19, 2022

Fixed by laminas/laminas-continuous-integration-action#110 ?

@Ocramius
Copy link
Member

Trying a re-run

@Ocramius
Copy link
Member

Nope

@fezfez fezfez force-pushed the php8.2 branch 2 times, most recently from ffb3e52 to 8c601db Compare November 8, 2022 10:15
@Ocramius
Copy link
Member

Ocramius commented Nov 8, 2022 

PHP Warning:  PHP Startup: Unable to load dynamic library 'sqlsrv.so' (tried: /usr/lib/php/20220829/sqlsrv.so (/usr/lib/php/20220829/sqlsrv.so: cannot open shared object file: No such file or directory), /usr/lib/php/20220829/sqlsrv.so.so (/usr/lib/php/20220829/sqlsrv.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
PHP Fatal error:  Cannot alias 'Laminas\Db\Sql\Ddl\Column\Float' as it is a built-in type in /github/workspace/test/unit/Sql/Ddl/Column/FloatTest.php on line 5

@fezfez
Copy link
Contributor Author

fezfez commented Nov 8, 2022

linked to microsoft/msphpsql#1420

This was referenced Nov 15, 2022
Closed
Closed
@fezfez
Drop support php 7, add php 8.2 support
605d6ef 
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@fezfez
Copy link
Contributor Author

fezfez commented Nov 18, 2022

@Ocramius seem good 🤓

@Ocramius
Copy link
Member

@fezfez could you clean up this git history a bit? Then good to go, IMO :)

@Ocramius Ocramius self-assigned this Nov 18, 2022
@Ocramius
Copy link
Member

Oh, never mind, you already did: thanks!

Ocramius
Ocramius approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius merged commit 0fb9d7a into laminas:2.16.x Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fezfez @Ocramius