Fix: prevent bound parameters being [null] when no parameters are given to Predicate#expression()
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: yes, I targeted |
…iven to `Predicate#expression()`
Around `laminas/laminas-db:2.10.1`, a regression was introduced, in which calling
`Laminas\Db\Sql\Predicate#expression("an_expression()")` led to crashes like following
in downstream consumers:
```
Laminas\Db\Sql\Exception\RuntimeException: The number of replacements in the expression does not match the number of parameters
vendor/laminas/laminas-db/src/Sql/Expression.php:151
vendor/laminas/laminas-db/src/Sql/Predicate/PredicateSet.php:178
vendor/laminas/laminas-db/src/Sql/Predicate/PredicateSet.php:178
vendor/laminas/laminas-db/src/Sql/Predicate/PredicateSet.php:178
vendor/laminas/laminas-db/src/Sql/AbstractSql.php:129
vendor/laminas/laminas-db/src/Sql/Select.php:633
```
This was because predicates were initialized with an `array{null}` by
default, when expressions like `$sql->where->expression("some_expression()")`
were used.
The usage of `$sql->where->expression("some_expression()", "foo")` remains
unchanged with this patch.
This fix targets `2.15.x`, and attempts to make predicates safe to use when no
parameters have been given.
While an existing test has indeed been changed, this shouldn't have any effect for
downstream consumers, since `Predicate#expression(string)` didn't work (so far)
anyway, due to the kind of crash highlighted above.
Ocramius
force-pushed
the
fix/predicate-expressions-should-not-have-values-to-be-bound-when-none-given
branch
from
575e28c
to
1c5ad3a
Compare
Ocramius
commented
Dec 5, 2022
Ocramius
deleted the
fix/predicate-expressions-should-not-have-values-to-be-bound-when-none-given
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Around
laminas/laminas-db:2.10.1, a regression was introduced, in which callingLaminas\Db\Sql\Predicate#expression("an_expression()")led to crashes like following in downstream consumers:This was because predicates were initialized with an
array{null}by default, when expressions like$sql->where->expression("some_expression()")were used.The usage of
$sql->where->expression("some_expression()", "foo")remains unchanged with this patch.This fix targets
2.15.x, and attempts to make predicates safe to use when no parameters have been given.While an existing test has indeed been changed, this shouldn't have any effect for downstream consumers, since
Predicate#expression(string)didn't work (so far) anyway, due to the kind of crash highlighted above.