Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static return type in RequestTrait #113

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix static return type in RequestTrait #113

merged 1 commit into from
Jul 28, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 28, 2022

Q A
Documentation yes
QA yes

Description

Solves psalm issues here and for consumers where a call to ServerRequest::withWhatever() would be inferred as RequestInterface rather than ServerRequestInterface

@gsteel
Fix static return type in RequestTrait
50d766a 
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 2.14.0 milestone Jul 28, 2022
Ocramius
Ocramius approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Jul 28, 2022
@Ocramius Ocramius merged commit 6cb35f6 into laminas:2.14.x Jul 28, 2022
@gsteel gsteel deleted the psr-static-return branch July 28, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Documentation Enhancement
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @Ocramius