Add UriFactory::createFromSapi()
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method will provide a public API to create Uri instances from SERVER context. This helps libraries that depend on diactoros and have their own ServerRequest or Uri implementations use the logic in diactoros more efficiently. Signed-off-by: Mark Story <mark@mark-story.com>
Ocramius
requested changes
Nov 21, 2022
|
/cc @froschdesign for getting guidance on the docs section |
|
BTW, overall direction of this patch is good 👍 |
Signed-off-by: Mark Story <mark@mark-story.com>
|
I've resolved all but one of psalm's complaints. The remaining MixedArgumentTypeCoercion was added to the baseline file beside the existing one in the same method. |
Ocramius
added
Awaiting Maintainer Response
and removed
Awaiting Maintainer Response
labels
|
Went through it again: I know most code is just transposed as-is, so we're good here. Releasing 🚢 |
Ocramius
changed the title
UriFactory::createFromSapi()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method will provide a public API to create Uri instances from SERVER context. This helps libraries that depend on diactoros and have their own ServerRequest or Uri implementations use the logic in diactoros more efficiently.
I wanted to get a rough draft of this up for feedback. If it is headed in the right direction, I have a few TODOs remaining:
factoriessection, but would appreciate any direction here.If there are other requirements that need to be met let me know 😄
Refs #122