-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing "return" in aliased functions. #30
Conversation
ADmad
commented
Jan 2, 2020
•
edited
Loading
edited
Q | A |
---|---|
Bugfix | yes |
BC Break | no |
New Feature | no |
RFC | no |
Anything holding up merging this? |
@ADmad more works needs to be done for those than just merge it. It is being handled. |
@Xerkus Thanks for the update. |
I've reviewed, and these are present from release 1.8.0 on. What I'll be doing is applying the patch to each release and issuing a patch release (e.g., 1.8.0p1). I've confirmed that Composer handles these properly — i.e., they take precedence over the stable tag they're applied against. Once I've applied to all releases, I'll apply to master and issue a new bugfix release. |
Just for reference CakePHP uses |
Add missing "return" in aliased functions.
… develop Forward port #30 Conflicts: CHANGELOG.md
I've tagged 2.2.2 with the change, and issued the following patch releases:
|