Clarify how zero-valued header parsing changed from diactoros 1.x to 2.x #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florian Hofsaess florian.hofsaess@check24.de
Description
Since the old implementation didn't add headers with
'0'
as content there is a significant change in parsing headers. That said thehasHeader
will lead to true starting with ^2Especially when headers are used for handling specific logic it will lead to a significant impact.
I'd say that the old implementation was buggy here. Fixing this bug should be mentioned in documentation to enable users to review their usages of
hasHeader
andgetHeaders
activly