-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove maglnet/composer-require-checker as it is now in CI #35
base: 2.11.x
Are you sure you want to change the base?
remove maglnet/composer-require-checker as it is now in CI #35
Conversation
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Is it planned to get composer-require-checker installed by default in the ci-action container? |
@gsteel Yeah I jumped the gun on this as I remember seeing that it creates the job in the CI matrix action, and assumed that the tooling was installed in there too. Then I looked at adding it and realised we're in the same position as using composer to check semver ranges, we need PHP in the node image. This is ready to go once that is worked out however. |
That's great news - getting it installed on older PHP versions is a pain. So once implemented, it'll run require-checker on 8.0 as opposed to the matrix default stable? |
Ideally, I don't think it should matter as long as it can check the |
Do we have a blocker PR that we can reference? I still see it running |
No PR yet, I thought this work was already done after checking the matrix, I missed that it was calling it from |
Description
This PR:
maglnet/composer-require-checker
as a dependency as it is now run inlaminas/laminas-ci-matrix-action
(closes Update dependency maglnet/composer-require-checker to v4 #33)phpunit/phpunit
to the minimum installable version