Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing description for usage in a laminas-mvc based application #36

Merged

Conversation

froschdesign
Copy link
Member

No description provided.

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign froschdesign added Bug Something isn't working Documentation labels Dec 19, 2022
@froschdesign froschdesign added this to the 3.9.1 milestone Dec 19, 2022
@froschdesign froschdesign force-pushed the hotfix/docs/mvc-application-integration branch from 77aa307 to 82ebb17 Compare December 19, 2022 19:29
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign froschdesign force-pushed the hotfix/docs/mvc-application-integration branch from 82ebb17 to 7a93233 Compare December 19, 2022 19:34
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a number of suggestions; overall, structure and the example are fantastic!

Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign froschdesign force-pushed the hotfix/docs/mvc-application-integration branch from f164cd5 to 6994bf3 Compare December 20, 2022 08:32
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 IMO :)

@Ocramius Ocramius merged commit c2d6db8 into laminas:3.9.x Dec 20, 2022
@Ocramius Ocramius self-assigned this Dec 20, 2022
@froschdesign froschdesign deleted the hotfix/docs/mvc-application-integration branch December 20, 2022 12:47
@Ocramius
Copy link
Member

Thanks @froschdesign, @weierophinney, @gsteel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants