Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 Support Added #56

Merged
merged 3 commits into from
Nov 21, 2024
Merged

PHP8.4 Support Added #56

merged 3 commits into from
Nov 21, 2024

Conversation

cod43156
Copy link
Contributor

@cod43156 cod43156 commented Oct 3, 2024

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cod43156

Please wait for #58 to be merged and then rebase.

There are deprecations here on 8.4 with lowest deps that are not failing CI.

#58 will either fix these, or reveal any problems

@gsteel gsteel added this to the 3.14.0 milestone Oct 30, 2024
@samsonasik
Copy link
Member

@cod43156 please rebase

Signed-off-by: cod43156 <cod43156@adobe.com>
@cod43156
Copy link
Contributor Author

cod43156 commented Nov 7, 2024

@cod43156 please rebase

@samsonasik rebased

@gsteel gsteel self-assigned this Nov 21, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cod43156 👍

@gsteel gsteel merged commit 1837caf into laminas:3.14.x Nov 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants