Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.4 #275

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Allow PHP 8.4 #275

merged 3 commits into from
Oct 9, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Aug 3, 2024

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

  • composer bump --dev-only
  • psalm baseline updated due to deprecated feature

Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
@gsteel
Copy link
Member

gsteel commented Aug 3, 2024

I'm reluctant to baseline all the deprecations from laminas-validator. Dealing with them now will make upgrading to v3, when it gets released, a lot easier. Merging this PR will mute all those issues…
🤔

@Xerkus
Copy link
Member

Xerkus commented Aug 4, 2024

php 8.4 CANNOT be declared compatible while it is in alpha.

@fezfez
Copy link
Contributor Author

fezfez commented Aug 4, 2024

php 8.4 CANNOT be declared compatible while it is in alpha.

I've seen that the job has begun https://github.com/orgs/laminas/projects/37 maybe it's unclear inside the laminas maintener community?

@fezfez
Copy link
Contributor Author

fezfez commented Aug 4, 2024

I'm reluctant to baseline all the deprecations from laminas-validator. Dealing with them now will make upgrading to v3, when it gets released, a lot easier. Merging this PR will mute all those issues… 🤔

Maybe you should create a 4.0.x branch with the 3.21.x before merging?

@Xerkus
Copy link
Member

Xerkus commented Aug 4, 2024

PHP 8.4 is in alpha release. It can introduce incompatibilities or even BC breaks. It happened before.
Releases with PHP 8.4 added to the range will become incompatible in such occurrence but it is impossible to retroactively change the range for past releases.

@fezfez
Copy link
Contributor Author

fezfez commented Aug 4, 2024

According to https://php.watch/rfcs and https://wiki.php.net/todo/php84

The feature freeze is on 13 august, only two RFCs can be merge for 8.4 and none of them can lead to breaking the package, otherwise I understand that's waiting 10 day before merging is not a big deal 👍

Edit : php.watch same to not be up to date, more rfcs can be merge in 8.4 according to https://wiki.php.net/rfc

@Xerkus
Copy link
Member

Xerkus commented Aug 6, 2024

PRs are desirable to highlight any coming issues as well as patches dealing with future compat.

It's the releasing with 8.4 that is premature. Ideally we would want to wait for rc which is in about a month

@fezfez
Copy link
Contributor Author

fezfez commented Sep 27, 2024

@Xerkus RC is out but the build is always with alpha, is there something to be done?

@froschdesign
Copy link
Member

I have re-run all jobs, but the alpha version is still being used. 🤷🏻‍♂️


I have fixed the problems in the documentation: #278

@fezfez
Copy link
Contributor Author

fezfez commented Oct 9, 2024

@froschdesign it's rc1 now :)

@froschdesign froschdesign added this to the 3.21.0 milestone Oct 9, 2024
@froschdesign froschdesign merged commit 653c869 into laminas:3.21.x Oct 9, 2024
17 checks passed
@froschdesign
Copy link
Member

@fezfez
Thank you for your time and this contribution! 👍

@Xerkus
Copy link
Member

Xerkus commented Oct 9, 2024

Merge branch 'laminas:3.21.x' into php8.4

@fezfez Please use rebase

@froschdesign
Copy link
Member

The topic can be found in the contributing guidelines: Keeping Up-to-Date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants