-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHP 8.4 #275
Allow PHP 8.4 #275
Conversation
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
I'm reluctant to baseline all the deprecations from laminas-validator. Dealing with them now will make upgrading to v3, when it gets released, a lot easier. Merging this PR will mute all those issues… |
php 8.4 CANNOT be declared compatible while it is in alpha. |
I've seen that the job has begun https://github.com/orgs/laminas/projects/37 maybe it's unclear inside the laminas maintener community? |
Maybe you should create a 4.0.x branch with the 3.21.x before merging? |
PHP 8.4 is in alpha release. It can introduce incompatibilities or even BC breaks. It happened before. |
According to https://php.watch/rfcs and https://wiki.php.net/todo/php84 The feature freeze is on 13 august, only two RFCs can be merge for 8.4 and none of them can lead to breaking the package, otherwise I understand that's waiting 10 day before merging is not a big deal 👍 Edit : php.watch same to not be up to date, more rfcs can be merge in 8.4 according to https://wiki.php.net/rfc |
PRs are desirable to highlight any coming issues as well as patches dealing with future compat. It's the releasing with 8.4 that is premature. Ideally we would want to wait for rc which is in about a month |
@Xerkus RC is out but the build is always with alpha, is there something to be done? |
I have re-run all jobs, but the alpha version is still being used. 🤷🏻♂️ I have fixed the problems in the documentation: #278 |
@froschdesign it's rc1 now :) |
@fezfez |
@fezfez Please use rebase |
The topic can be found in the contributing guidelines: Keeping Up-to-Date. |
Description