Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support PHP 8.3 #53

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Update to support PHP 8.3 #53

merged 6 commits into from
Dec 5, 2023

Conversation

nusphere
Copy link
Contributor

This commit updates several dependencies in the composer.lock. Key updates include removing 'container-interop/container-interop', and upgrading 'laminas/laminas-servicemanager', 'laminas/laminas-stdlib' and 'doctrine/instantiator' among others. These upgrades ensure better compatibility and performance with newer versions of PHP.

Q A
QA yes

Description

This PR allow to install this package with PHP 8.3. Since the there is a dev requirement to laminas/laminas-db - the PR laminas/laminas-db#293 is required

@nusphere
Update composer dependencies
fdcf92e 
This commit updates several dependencies in the composer.lock. Key updates include removing 'container-interop/container-interop', and upgrading 'laminas/laminas-servicemanager', 'laminas/laminas-stdlib' and 'doctrine/instantiator' among others. These upgrades ensure better compatibility and performance with newer versions of PHP.

Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@nusphere
Update Laminas library and make improvements to test suite
3ec60ac 
The Laminas library has been updated to the latest version, which includes various dependency updates. Additionally, improvements have been made to the test suite by adding more attributes to classes for better readability and maintainability. The new attributes will help track the state and behavior of instances throughout tests. The tests will be more independent and easier to understand as a result.

Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@nusphere
Update Laminas library version requirement in composer.json
14881f7 
The Laminas' version requirement has been updated to "^3.21.0" from "^3.3.0", ensuring compatibility with its latest release. This version upgrade includes various dependency updates that will improve system's performance and stability.

Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@nusphere
Copy link
Contributor Author

@weierophinney - I don't know why the errors in the codestyle check fail, I haven't adjusted anything else.

I only had to adapt the tests because the corresponding test trait was adapted through the PHPUnit 10 integration in the ServiceManager.

https://github.com/laminas/laminas-servicemanager/blob/3.21.x/src/Test/CommonPluginManagerTrait.php#L105C59-L105C59

This resulted in a drop of PHP 8.0 for me - which is now obsolete anyway

@froschdesign froschdesign added this to the 2.17.0 milestone Nov 30, 2023
@froschdesign
Copy link
Member

Blocked by: laminas/laminas-db#293

@weierophinney
Copy link
Member

I don't know why the errors in the codestyle check fail, I haven't adjusted anything else.

It's because you ran a composer update, and it picked up a version of laminas-servicemanager that now no longer replaces container-interop.

Do the following:

  • Update the laminas-servicemanager dependency to ^3.12
  • Update all the factories to typehint against Psr\Container\ContainerInterface instead of Interop\Container\ContainerInterface,

These should be done anyways, and doing it during a PHP minor bump is a great time to do it.

@nusphere
Replace Interop Interfaces with PSR Interfaces
9ccc155 
Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@nusphere
remove wrong dev requirement
9238617 
Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@nusphere
Copy link
Contributor Author

nusphere commented Dec 2, 2023

@weierophinney The fact that I have already raised the service manager to ^3.21 obviously explains the error.

I now have all pipes clean, except for the fact that laminas-db still needs a release.

@driehle driehle mentioned this pull request Dec 5, 2023
Merged
@froschdesign
Copy link
Member

@weierophinney
Do we really need a new release of laminas-db here? laminas-validator works also for PHP 8.3 without a new release of laminas-db. See: laminas/laminas-validator#205
Or have I overlooked something?

@steffendietz
Copy link

@froschdesign
The latest release of laminas/laminas-db does not support PHP 8.3. So I would assume a release supporting PHP 8.3 is needed.

The reason laminas/laminas-validator#205 went through is probably this change here:
https://github.com/laminas/laminas-validator/blob/13d1e27e474b48365c54aa370a02b17a7891b766/.laminas-ci.json#L3

@froschdesign
Copy link
Member

@steffendietz
Then add or update this also here.

@nusphere
update laminas ci settings
1d2ec14 
Signed-off-by: Sebastian Hopfe <s.hopfe@me.com>
@Ocramius Ocramius self-assigned this Dec 5, 2023
Ocramius
Ocramius approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nusphere!

@Ocramius Ocramius merged commit f24c4c7 into laminas:2.17.x Dec 5, 2023
11 of 14 checks passed
@Ocramius Ocramius changed the title Update PHP 8.3 Update to support PHP 8.3 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.3
Status: Done
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nusphere @froschdesign @weierophinney @steffendietz @Ocramius