Added php8.1 support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shankar Konar <konar.shankar2013@gmail.com>
konarshankar07
force-pushed
the
php8.1-support
branch
from
e9cd5f4
to
86c7fec
Compare
|
Hello @ihor-sviziev |
|
First of all - keep the php 7.3 and 7.4 support as there no reason for dropping support without any changes in code. After that, phpcs tests should pass |
|
I have readded the php 7.3 and 7.4 support |
Signed-off-by: Shankar Konar <konar.shankar2013@gmail.com>
konarshankar07
force-pushed
the
php8.1-support
branch
from
d61e662
to
69837fd
Compare
Signed-off-by: Shankar Konar <konar.shankar2013@gmail.com>
Xerkus
reviewed
Oct 9, 2021
composer.json
Outdated
| @@ -25,13 +25,13 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "php": "^7.3 || ~8.0.0", | |||
| "php": "^7.3 || ^7.4 || ~8.0.0 || ~8.1.0", | |||
There was a problem hiding this comment.
^7.4 is not needed, it is already in range
There was a problem hiding this comment.
I have removed the 7.4 version
Signed-off-by: Shankar Konar <konar.shankar2013@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Declared php 8.1 support
magento/magento2#34242