Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rand: Drop exceptions specific to php 5.x #7

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Rand: Drop exceptions specific to php 5.x #7

merged 1 commit into from
Jan 22, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 22, 2021

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes

Description

Drops code specific to PHP 5.x, The code is no longer reachable for PHP 7+.

See discussion at:

@glensc glensc mentioned this pull request Jan 22, 2021
Merged
@glensc
Rand: Drop exceptions specific to php 5.x
9228a3f 
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@Ocramius Ocramius added this to the 3.4.0 milestone Jan 22, 2021
@Ocramius Ocramius self-assigned this Jan 22, 2021
Ocramius
Ocramius approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glensc

@Ocramius Ocramius merged commit 9ce634c into laminas:3.4.x Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @Ocramius