Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Renovate with reusable workflows #104

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Prepare for Renovate with reusable workflows #104

merged 3 commits into from
Feb 24, 2022

Conversation

ghostwriter
Copy link
Contributor

Q A
QA yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

  • Configure minimum supported PHP version
  • Update composer dependencies
  • Update to reusable Continuous Integration workflow
  • Update to reusable Automatic Releases workflow

@Ocramius Ocramius added this to the 3.4.0 milestone Feb 21, 2022
Ocramius
Ocramius requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about target branch on this one - 4.0.x seems to be totally borked, and 3.4.x is missing

@ghostwriter ghostwriter requested a review from Ocramius February 22, 2022 16:20
Ocramius
Ocramius requested changes Feb 24, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by other maintainers, 4.0.x will be deleted: let's rebase this onto 3.x, and target that, and then we can merge and drop 4.0.x (will do after patch is merged, to avoid auto-closing it)

@ghostwriter
Configure minimum supported PHP version
76ec832 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update to reusable continuous-integration workflow
0c7442d 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update to reusable automatic-releases workflow
98dbb66 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter ghostwriter changed the base branch from 4.0.x to 3.4.x February 24, 2022 15:45
@ghostwriter ghostwriter requested a review from Ocramius February 24, 2022 15:46
@Ocramius Ocramius self-assigned this Feb 24, 2022
Ocramius
Ocramius approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghostwriter!

@Ocramius Ocramius merged commit 4beede6 into laminas:3.4.x Feb 24, 2022
@ghostwriter ghostwriter deleted the feature/renovate branch February 24, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
3.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwriter @Ocramius