Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type of AbstractRestfulController::patch #115

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update return type of AbstractRestfulController::patch #115

merged 1 commit into from
Apr 21, 2022

Conversation

gregtyler
Copy link
Contributor

Q A
Documentation no (kind of...)
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

The return type should be mixed, not array, so that for example ViewModel is a valid return.

Fixes #114

@Xerkus Xerkus changed the base branch from 3.4.x to 3.3.x April 21, 2022 15:27
@Xerkus
Copy link
Member

Xerkus commented Apr 21, 2022

Since this a bugfix, please rebase against 3.3.x branch for the next patch release.

@Xerkus Xerkus added this to the 3.3.4 milestone Apr 21, 2022
@Xerkus Xerkus added the Bug Something isn't working label Apr 21, 2022
It should return `mixed`, not `array`.

Fixes #114

Signed-off-by: Greg Tyler <greg.tyler@digital.justice.gov.uk>
@gregtyler
Copy link
Contributor Author

@Xerkus Sorry, got my local Git in a bit of a state, should be good now 👍🏽

@Xerkus
Copy link
Member

Xerkus commented Apr 21, 2022

@gregtyler thank you

@Xerkus Xerkus merged commit b373af6 into laminas:3.3.x Apr 21, 2022
@gregtyler gregtyler deleted the patch-1 branch April 21, 2022 15:36
@Xerkus Xerkus modified the milestones: 3.3.4, 3.4.0 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractRestfulController::patch returns array, not mixed
2 participants