Migrate laminas-coding-standard to v2. Introduce strict types #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei <aleksey@xerkus.pro>
Signed-off-by: Aleksei <aleksey@xerkus.pro>
Signed-off-by: Aleksei <aleksey@xerkus.pro>
Signed-off-by: Aleksei <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/migrate-coding-standard
branch
from
0fd6c6e to
edea9ed
Compare
Signed-off-by: Aleksei <aleksey@xerkus.pro>
|
I am going to split introduction of type declarations into separate PR(s) to avoid unneeded work with other breaking changes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade coding standard to v2. This would introduce strict types.
To fully utilize strict types also introduce typehints for parameters, return
values and properties. This is BC breaking change.