Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 3.5.0 into 4.0.x #141

Merged
merged 11 commits into from
Mar 14, 2023
Merged

Conversation

github-actions[bot]
Copy link

Release Notes for 3.5.0

3.5.0

  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1

Enhancement

Xerkus and others added 9 commits September 20, 2022 22:44
Bumps [laminas/laminas-diactoros](https://github.com/laminas/laminas-diactoros) from 2.8.0 to 2.14.0.
- [Release notes](https://github.com/laminas/laminas-diactoros/releases)
- [Commits](laminas/laminas-diactoros@2.8.0...2.14.0)

---
updated-dependencies:
- dependency-name: laminas/laminas-diactoros
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…nas-diactoros-2.14.0

Bump laminas/laminas-diactoros from 2.8.0 to 2.14.0
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Drop support php 7, add php 8.2 support
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Apply PHP 8.0 Syntax and constructor promotion
@Ocramius Ocramius force-pushed the 3.5.x-merge-up-into-4.0.x_28zUTsCU branch from 7d62846 to 262ec80 Compare October 21, 2022 16:13
@Ocramius Ocramius requested review from Xerkus and gsteel October 21, 2022 16:14
@Ocramius
Copy link
Member

Requesting a review by others: my eyes are swirling after this last merge.

And yes, --prefer-lowest has some failures, to be investigated/fixed before merge

@samsonasik
Copy link
Member

static closure in lowest phpunit seems cause it:

There were 2 errors:

1) LaminasTest\Mvc\Service\ViewFeedStrategyFactoryTest::testReturnsFeedStrategy
Cannot bind an instance to a static closure

/github/workspace/src/Service/ViewFeedStrategyFactory.php:27
/github/workspace/test/Service/ViewFeedStrategyFactoryTest.php:29

2) LaminasTest\Mvc\Service\ViewManagerFactoryTest::testReturnsHttpViewManager
Cannot bind an instance to a static closure

@Ocramius I can push to remove static if you want for both methods above.

@Ocramius
Copy link
Member

@samsonasik feel free to push to this branch 👍

Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@samsonasik
Copy link
Member

@Ocramius done 8b92ee5

@samsonasik
Copy link
Member

All green 🎉

@Ocramius
Copy link
Member

Oooh, we still have prophecy here...

We should drop it in 3.6.x and merge-up, at some point.

@Ocramius
Copy link
Member

@samsonasik green OK, but still need a careful review :)

@Xerkus Xerkus self-assigned this Oct 21, 2022
@Xerkus Xerkus merged commit 5f5dae2 into 4.0.x Mar 14, 2023
@Xerkus Xerkus deleted the 3.5.x-merge-up-into-4.0.x_28zUTsCU branch March 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants