Fix PHP 8.2 deprecations in tests #150
Conversation
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Optional dependencies for deprecated middleware functionality are not installable on PHP 8 unless platform is ignored. Drop optional dev dependencies and tests depending on them. Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
|
Not sure if it should be added to dev dependencies to avoid the issue and satisfy CI |
…lowest Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
| @@ -1,135 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I think we should drop these in 4.x, not 3.x 🤔
There was a problem hiding this comment.
They are dropped in 4.x.
hey are also not usable in PHP 8 and they prevent proper php version resolution.
They were requiring PHP below 8, but again I see that "merge" commit: ad9267a#diff-388c804d6485a66f01b14f8f443ca49bfe180c14bb340fac584ff613129f6363L23
There was a problem hiding this comment.
Full reasons for dropping it:
- This requires dependencies not installable on any supported PHP versions. Using it is already on own risk.
- It interferes with dependency resolution because platform ignores are required. Renovate can not operate on this.
- Optional stratigility version supported here was tested on up to PHP 7.2.
- This was deprecated since laminas-mvc 3.2
- This functionality is entirely replaced by laminas/laminas-mvc-middleware 1.0. Replacement does not use tested code and properly declares dependencies.
- No changes will be accepted for either of the pieces tested by removed tests.
| @@ -1,545 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Should be dropped in 4.x rather than 3.x?
Description
Remove Middleware tests and their dev/optional dependencies since dependencies are not installable on PHP 8 unless platform is ignored and this package no longer supports any of PHP 7 versions. This allows to drop platform ignore used for CI.
Declare properties in tests that were declared dynamically to fix PHP 8.2 deprecations.