Deprecate middleware listener #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerkus
force-pushed
the
feature/deprecate-middleware-listener
branch
from
a1beaf4 to
fd813d6
Compare
Xerkus
commented
Jun 9, 2020
froschdesign
reviewed
Jun 9, 2020
docs/book/middleware.md
Outdated
Comment on lines
29
to
30
| `laminas-mvc-middleware` is an MVC module that needs to be registered with | ||
| laminas-mvc application to function. |
There was a problem hiding this comment.
We can added a page with instructions for installations in the documentation of laminas-mvc-middleware which covers the module registration.
An example can be found in the documentation of laminas-i18n:
- Page in docs: https://docs.laminas.dev/laminas-i18n/installation/
- Configuration: https://github.com/laminas/laminas-i18n/blob/327fdc2d07572e273f8122f46b52c7475a730826/mkdocs.yml#L48-L52
The link can then be added here.
Xerkus
force-pushed
the
feature/deprecate-middleware-listener
branch
from
08ba8ff to
a654cb5
Compare
|
@froschdesign I updated the middleware documentation page to directs to laminas-mvc-middleware. Existing documentation for the feature is dropped here since it was extracted along with the code into laminas-mvc-middleware. |
Merged
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/deprecate-middleware-listener
branch
from
8e71741 to
314d580
Compare
weierophinney
requested changes
Dec 14, 2020
Xerkus
commented
Dec 14, 2020
Co-authored-by: Matthew Weier O'Phinney <matthew@weierophinney.net> Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
force-pushed
the
feature/deprecate-middleware-listener
branch
from
b7568eb to
241bca6
Compare
weierophinney
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description