Fully clean up quick start #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove a lot of filler text of type "he's what you're about to do" and "here's what you just did" - Choose more concise phrasing where possible - Introduce the page with a clear description of what we're about to build and the steps involved - Avoid euphemistic and exaggerating adjectives - Remove information about custom modules to lighten this guide; add a link to the modules tutorial instead - Since we no longer use custom modules, replace `<module name>` with `Application` to not leave devs to figure any of this out - There was some leftover info about the deprecated laminas-mvc-console - Say which file the code example belongs to in a uniform way - Replace "foo" and "bar" with something more meaningful - Add code comments to the controller example as opposed to post-example explanations - Add Learn More section with links Signed-off-by: Anna Filina <afilina@gmail.com>
Since this patch touches basically the whole file, I've applied the one-sentence-per-line rule everywheere. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
@froschdesign I'm happy with the changes; if they look good to you, please go ahead and merge. |
boesing
reviewed
Jan 27, 2022
froschdesign
requested changes
Jan 27, 2022
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com>
Signed-off-by: Anna Filina <afilina@gmail.com>
afilina
commented
Jan 28, 2022
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Frank Brückner <info@froschdesignstudio.de>
Signed-off-by: Anna Filina <afilina@gmail.com>
afilina
commented
Jan 28, 2022
Signed-off-by: Anna Filina <afilina@gmail.com> Co-authored-by: Aleksei Khudiakov <aleksey@xerkus.pro>
Xerkus
approved these changes
Jan 28, 2022
Signed-off-by: Anna Filina <afilina@gmail.com>
froschdesign
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<module name>withApplicationto not leave devs to figure any of this out