Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated factories #170

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented Jan 26, 2023

Q A
BC Break yes
QA yes

Description

This removes the following deprecated factories (and the deprecated initializer):

  • Laminas\ServiceManager\AbstractFactoryInterface
  • Laminas\ServiceManager\DelegatorFactoryInterface
  • Laminas\ServiceManager\FactoryInterface
  • Laminas\ServiceManager\InitializerInterface

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to the 4.0.0 milestone Jan 26, 2023
…names

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@lcobucci
Copy link
Member

lcobucci commented Feb 15, 2023

@boesing shouldn't we change the target branch and rebase this?
Apart from this detail, the patch LGTM. Nice and clean 👍

@boesing boesing changed the base branch from 3.21.x to 4.0.x February 15, 2023 20:39
@boesing
Copy link
Member Author

boesing commented Feb 15, 2023

Absolutely! Thanks. Missed the target branch here. Fixed it, seems to have no conflicts.

@boesing boesing merged commit a3f3c32 into laminas:4.0.x Feb 15, 2023
@boesing boesing deleted the qa/remove-deprecated-factories branch February 15, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants