Merge release 3.16.1 into 3.17.x #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Before this change, in following example, `@psalm-self-out` would delete inheritance
type information at runtime.
For example:
```php
class Foo implements ParentType {
// ...
}
$foo = new Foo();
$foo->methodWithSelfOut();
/** @psalm-trace $foo */ // produces `ParentType`
```
This change corrects that, preserving `static` in the type information.
… type inference Cases like following break completely with `@psalm-self-out`: ```php $o = new ArrayObject(['foo' => 'bar']); $o->baz = 'taz'; // `never` due to `'foo'&'bar'` not being possible ``` Rolling back the entire `psalm-self-out` improvement: too aggressive, and not practically useful on these mutable data containers.
…ences Dropping `@psalm-self-out` to avoid incorrect type inference in inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.16.1
3.16.x bugfix release (patch)
3.16.1
Bug
@psalm-self-outto avoid incorrect type inference in inheritance thanks to @Ocramius