Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates ConsoleModel and ConsoleRenderer for removal in 3.0.0 #101

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Dec 31, 2021

Q A
Documentation no - There does not appear to be any docs related to console in the docs tree
Bugfix no
BC Break no
New Feature yes
RFC yes
QA no

Description

Considering that laminas-console and mvc-console are both abandoned, this pull deprecates the console model and renderer for removal in 3.0

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Dec 31, 2021
@Ocramius Ocramius added this to the 2.17.0 milestone Dec 31, 2021
@Ocramius
Copy link
Member

Also here, we need to first prepare the 2.17.x branch, before merging

@gsteel
Copy link
Member Author

gsteel commented Dec 31, 2021

Also here, we need to first prepare the 2.17.x branch, before merging

Thanks @Ocramius … There's a lot of stuff to do in order to prepare for a 3.0 - the dev dependency on MVC and MVC-I18N also keeps failing CI… is it feasible to get some kind of dev branch running for 3.0, or some way to get deps installed in 3.0 so that we can get the pulls breaking BC merged to reduce conflicts? I've tried mucking about with branch aliases to solve the MVC related stuff, but my composer-fu is either not up to scratch, or, those branch aliases need to be committed or something…

@Ocramius
Copy link
Member

AFAIK 3.0.x exists, which is why 2.17.x was not automatically created

@Ocramius Ocramius changed the base branch from 2.16.x to 2.17.x January 8, 2022 16:15
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

A rebase is needed here

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel force-pushed the deprecate-laminas-console branch from 0dc940f to 1042566 Compare January 8, 2022 16:27
@Ocramius Ocramius changed the title Deprecates ConsoleModel and ConsoleRenderer for removal in 3.0 Deprecates ConsoleModel and ConsoleRenderer for removal in 3.0.0 Jan 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

Thanks @gsteel!

@Ocramius Ocramius merged commit 8b7b119 into laminas:2.17.x Jan 8, 2022
@gsteel gsteel deleted the deprecate-laminas-console branch January 8, 2022 16:38
gsteel added a commit to gsteel/laminas-view that referenced this pull request Jan 8, 2022
- Removes Console Model and Renderer
- Removes laminas-console from dev dependencies

Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel added a commit to gsteel/laminas-view that referenced this pull request Jan 31, 2022
- Removes Console Model and Renderer
- Removes laminas-console from dev dependencies

Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel added a commit to gsteel/laminas-view that referenced this pull request Feb 1, 2022
- Removes Console Model and Renderer
- Removes laminas-console from dev dependencies

Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel added a commit to gsteel/laminas-view that referenced this pull request Mar 23, 2022
- Removes Console Model and Renderer
- Removes laminas-console from dev dependencies

Signed-off-by: George Steel <george@net-glue.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants