-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecates ConsoleModel
and ConsoleRenderer
for removal in 3.0.0
#101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Also here, we need to first prepare the |
Thanks @Ocramius … There's a lot of stuff to do in order to prepare for a 3.0 - the dev dependency on MVC and MVC-I18N also keeps failing CI… is it feasible to get some kind of dev branch running for 3.0, or some way to get deps installed in 3.0 so that we can get the pulls breaking BC merged to reduce conflicts? I've tried mucking about with branch aliases to solve the MVC related stuff, but my composer-fu is either not up to scratch, or, those branch aliases need to be committed or something… |
AFAIK |
A rebase is needed here |
Signed-off-by: George Steel <george@net-glue.co.uk>
0dc940f
to
1042566
Compare
ConsoleModel
and ConsoleRenderer
for removal in 3.0.0
Thanks @gsteel! |
- Removes Console Model and Renderer - Removes laminas-console from dev dependencies Signed-off-by: George Steel <george@net-glue.co.uk>
- Removes Console Model and Renderer - Removes laminas-console from dev dependencies Signed-off-by: George Steel <george@net-glue.co.uk>
- Removes Console Model and Renderer - Removes laminas-console from dev dependencies Signed-off-by: George Steel <george@net-glue.co.uk>
- Removes Console Model and Renderer - Removes laminas-console from dev dependencies Signed-off-by: George Steel <george@net-glue.co.uk>
Description
Considering that laminas-console and mvc-console are both abandoned, this pull deprecates the console model and renderer for removal in 3.0