Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obsolete helpers #102

Merged
merged 3 commits into from
Jan 8, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Dec 31, 2021

Q A
Documentation yes
New Feature yes
RFC yes

Description

Flash and Quicktime are both long dead - these helpers can be removed in 3.0 yes?

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also here, we will need to change target branch before merging

@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

A rebase is needed here

gsteel added 2 commits January 8, 2022 16:24
Signed-off-by: George Steel <george@net-glue.co.uk>
…nd changing example usage from HtmlFlash to HtmlPage

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel force-pushed the deprecate-obsolete-helpers branch from eac2765 to 150824c Compare January 8, 2022 16:25
Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius Ocramius self-assigned this Jan 8, 2022
@Ocramius Ocramius merged commit 71286f0 into laminas:2.17.x Jan 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

Thanks @gsteel!

@gsteel gsteel deleted the deprecate-obsolete-helpers branch January 8, 2022 16:37
@gsteel gsteel mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants