Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up test annotations #134

Merged
merged 1 commit into from
Feb 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/Helper/AbstractHtmlElementTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ protected function setUp(): void
$this->helper->setView(new PhpRenderer());
}

/**
* @group #5991
*/
public function testWillEscapeValueAttributeValuesCorrectly(): void
{
self::assertEquals(
Expand Down
4 changes: 0 additions & 4 deletions test/Helper/AbstractTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
use LaminasTest\View\Helper\TestAsset\ConcreteHelper;
use PHPUnit\Framework\TestCase;

/**
* @group Laminas_View
* @group Laminas_View_Helper
*/
class AbstractTest extends TestCase
{
/** @var ConcreteHelper */
Expand Down
4 changes: 0 additions & 4 deletions test/Helper/BasePathTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
use Laminas\View\Helper\BasePath;
use PHPUnit\Framework\TestCase;

/**
* @group Laminas_View
* @group Laminas_View_Helper
*/
class BasePathTest extends TestCase
{
public function testBasePathWithoutFile(): void
Expand Down
6 changes: 0 additions & 6 deletions test/Helper/CycleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@
use Laminas\View\Helper;
use PHPUnit\Framework\TestCase;

/**
* Test class for Laminas\View\Helper\Cycle.
*
* @group Laminas_View
* @group Laminas_View_Helper
*/
class CycleTest extends TestCase
{
/** @var Helper\Cycle */
Expand Down
4 changes: 0 additions & 4 deletions test/Helper/DeclareVarsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@

use const DIRECTORY_SEPARATOR;

/**
* @group Laminas_View
* @group Laminas_View_Helper
*/
class DeclareVarsTest extends TestCase
{
private View $view;
Expand Down
6 changes: 0 additions & 6 deletions test/Helper/DoctypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
use Laminas\View\Helper\Doctype;
use PHPUnit\Framework\TestCase;

/**
* Test class for Laminas\View\Helper\Doctype.
*
* @group Laminas_View
* @group Laminas_View_Helper
*/
class DoctypeTest extends TestCase
{
/** @var Doctype */
Expand Down
6 changes: 0 additions & 6 deletions test/Helper/FlashMessengerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@

use function get_class;

/**
* Test class for Laminas\View\Helper\Cycle.
*
* @group Laminas_View
* @group Laminas_View_Helper
*/
class FlashMessengerTest extends TestCase
{
use ProphecyTrait;
Expand Down
4 changes: 0 additions & 4 deletions test/Helper/GravatarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
use function strtoupper;
use function urlencode;

/**
* @group Laminasview
* @group Laminasview_Helper
*/
class GravatarTest extends TestCase
{
/** @var Gravatar */
Expand Down
26 changes: 0 additions & 26 deletions test/Helper/HeadLinkTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@

use const PHP_EOL;

/**
* Test class for Laminas\View\Helper\HeadLink.
*
* @group Laminas_View
* @group Laminas_View_Helper
*/
class HeadLinkTest extends TestCase
{
/** @var Helper\HeadLink */
Expand Down Expand Up @@ -351,19 +345,13 @@ public function testDoesNotAllowDuplicateStylesheets(): void
$this->assertEquals(1, count($this->helper), var_export($this->helper->getContainer()->getArrayCopy(), true));
}

/**
* test for Laminas-2889
*/
public function testBooleanStylesheet(): void
{
$this->helper->appendStylesheet(['href' => '/bar/baz', 'conditionalStylesheet' => false]);
$test = $this->helper->toString();
$this->assertStringNotContainsString('[if false]', $test);
}

/**
* test for Laminas-3271
*/
public function testBooleanTrueConditionalStylesheet(): void
{
$this->helper->appendStylesheet(['href' => '/bar/baz', 'conditionalStylesheet' => true]);
Expand All @@ -372,11 +360,6 @@ public function testBooleanTrueConditionalStylesheet(): void
$this->assertStringNotContainsString('[if true]', $test);
}

/**
* @link https://getlaminas.org/issues/browse/Laminas-3928
*
* @issue Laminas-3928
*/
public function testTurnOffAutoEscapeDoesNotEncodeAmpersand(): void
{
$this->helper->setAutoEscape(false)->appendStylesheet('/css/rules.css?id=123&foo=bar');
Expand Down Expand Up @@ -430,9 +413,6 @@ public function testSetNextRelationship(): void
$this->assertStringContainsString('rel="next"', $test);
}

/**
* @issue Laminas-5435
*/
public function testContainerMaintainsCorrectOrderOfItems(): void
{
$this->helper->__invoke()->offsetSetStylesheet(1, '/test1.css');
Expand Down Expand Up @@ -460,18 +440,12 @@ public function testContainerMaintainsCorrectOrderOfItems(): void
$this->assertEquals($expected, $test);
}

/**
* @issue Laminas-10345
*/
public function testIdAttributeIsSupported(): void
{
$this->helper->appendStylesheet(['href' => '/bar/baz', 'id' => 'foo']);
$this->assertStringContainsString('id="foo"', $this->helper->toString());
}

/**
* @group 6635
*/
public function testSizesAttributeIsSupported(): void
{
$this->helper->appendStylesheet(['rel' => 'icon', 'href' => '/bar/baz', 'sizes' => '123x456']);
Expand Down
50 changes: 0 additions & 50 deletions test/Helper/HeadMetaTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@

use const PHP_EOL;

/**
* Test class for Laminas\View\Helper\HeadMeta.
*
* @group Laminas_View
* @group Laminas_View_Helper
*/
class HeadMetaTest extends TestCase
{
private HeadMeta $helper;
Expand Down Expand Up @@ -246,9 +240,6 @@ public function testToStringReturnsValidHtml(): void
$this->assertStringContainsString('name="title" content="' . $attributeEscaper('boo bah') . '"', $string);
}

/**
* @group Laminas-6637
*/
public function testToStringWhenInvalidKeyProvidedShouldConvertThrownException(): void
{
$this->helper->__invoke('some-content', 'tag value', 'not allowed key');
Expand Down Expand Up @@ -306,9 +297,6 @@ public function testStringRepresentationReflectsDoctype(): void
$this->assertStringContainsString('foo', $test);
}

/**
* @issue Laminas-2663
*/
public function testSetNameDoesntClobber(): void
{
$view = new View();
Expand All @@ -324,9 +312,6 @@ public function testSetNameDoesntClobber(): void
);
}

/**
* @issue Laminas-2663
*/
public function testSetNameDoesntClobberPart2(): void
{
$view = new View();
Expand All @@ -347,11 +332,6 @@ public function testSetNameDoesntClobberPart2(): void
$this->assertEquals($expected, $view->plugin('headMeta')->toString());
}

/**
* @link https://getlaminas.org/issues/browse/Laminas-3780
*
* @issue Laminas-3780
*/
public function testPlacesMetaTagsInProperOrder(): void
{
$view = new View();
Expand All @@ -375,9 +355,6 @@ public function testPlacesMetaTagsInProperOrder(): void
$this->assertEquals($expected, $view->plugin('headMeta')->toString());
}

/**
* @issue Laminas-5435
*/
public function testContainerMaintainsCorrectOrderOfItems(): void
{
$this->helper->offsetSetName(1, 'keywords', 'foo');
Expand All @@ -398,9 +375,6 @@ public function testContainerMaintainsCorrectOrderOfItems(): void
$this->assertEquals($expected, $test);
}

/**
* @issue Laminas-7722
*/
public function testCharsetValidateFail(): void
{
$view = new View();
Expand All @@ -410,9 +384,6 @@ public function testCharsetValidateFail(): void
$view->plugin('headMeta')->setCharset('utf-8');
}

/**
* @issue Laminas-7722
*/
public function testCharset(): void
{
$view = new View();
Expand Down Expand Up @@ -460,9 +431,6 @@ public function testCarsetWithXhtmlDoctypeGotException(): void
->setCharset('utf-8');
}

/**
* @group Laminas-9743
*/
public function testPropertyIsSupportedWithRdfaDoctype(): void
{
$this->view->doctype('XHTML1_RDFA');
Expand All @@ -474,9 +442,6 @@ public function testPropertyIsSupportedWithRdfaDoctype(): void
$this->assertEquals($expected, $this->helper->toString());
}

/**
* @group Laminas-9743
*/
public function testPropertyIsNotSupportedByDefaultDoctype(): void
{
try {
Expand All @@ -488,7 +453,6 @@ public function testPropertyIsNotSupportedByDefaultDoctype(): void
}

/**
* @group Laminas-9743
* @depends testPropertyIsSupportedWithRdfaDoctype
*/
public function testOverloadingAppendPropertyAppendsMetaTagToStack(): void
Expand All @@ -498,7 +462,6 @@ public function testOverloadingAppendPropertyAppendsMetaTagToStack(): void
}

/**
* @group Laminas-9743
* @depends testPropertyIsSupportedWithRdfaDoctype
*/
public function testOverloadingPrependPropertyPrependsMetaTagToStack(): void
Expand All @@ -508,7 +471,6 @@ public function testOverloadingPrependPropertyPrependsMetaTagToStack(): void
}

/**
* @group Laminas-9743
* @depends testPropertyIsSupportedWithRdfaDoctype
*/
public function testOverloadingSetPropertyOverwritesMetaTagStack(): void
Expand All @@ -517,9 +479,6 @@ public function testOverloadingSetPropertyOverwritesMetaTagStack(): void
$this->executeOverloadSet('property');
}

/**
* @issue 3751
*/
public function testItempropIsSupportedWithHtml5Doctype(): void
{
$this->view->doctype('HTML5');
Expand All @@ -531,9 +490,6 @@ public function testItempropIsSupportedWithHtml5Doctype(): void
$this->assertEquals($expected, $this->helper->toString());
}

/**
* @issue 3751
*/
public function testItempropIsNotSupportedByDefaultDoctype(): void
{
try {
Expand All @@ -545,7 +501,6 @@ public function testItempropIsNotSupportedByDefaultDoctype(): void
}

/**
* @issue 3751
* @depends testItempropIsSupportedWithHtml5Doctype
*/
public function testOverloadingAppendItempropAppendsMetaTagToStack(): void
Expand All @@ -555,7 +510,6 @@ public function testOverloadingAppendItempropAppendsMetaTagToStack(): void
}

/**
* @issue 3751
* @depends testItempropIsSupportedWithHtml5Doctype
*/
public function testOverloadingPrependItempropPrependsMetaTagToStack(): void
Expand All @@ -565,7 +519,6 @@ public function testOverloadingPrependItempropPrependsMetaTagToStack(): void
}

/**
* @issue 3751
* @depends testItempropIsSupportedWithHtml5Doctype
*/
public function testOverloadingSetItempropOverwritesMetaTagStack(): void
Expand All @@ -574,9 +527,6 @@ public function testOverloadingSetItempropOverwritesMetaTagStack(): void
$this->executeOverloadSet('itemprop');
}

/**
* @group Laminas-11835
*/
public function testConditional(): void
{
$html = $this->helper->appendHttpEquiv('foo', 'bar', ['conditional' => 'lt IE 7'])->toString();
Expand Down
Loading