Added laminas/laminas-servicemanager as non-dev dependency, required at runtime
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psr\Container and Interop\Container are too. Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Feb 21, 2022
Ocramius
approved these changes
Feb 21, 2022
Ocramius
changed the title
laminas/laminas-servicemanager as non-dev dependency, required at runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Psr\ContainerandInterop\Containerare too…This is something I thought would be good to get into 2.20 before it gets released - In 3.0, if we introduce a config provider, this will mean that we'll be able to import the psalm types for factory configuration etc. I think that
^3.6is the feasible minimum for service menager for this, currently though, I'd find it unlikely that installing view on PHP 7.4 gets you anything less that3.10of service manager.