Cleanup BasePath View Helper #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark helper as final and deprecate inherited methods / inheritance - Add constructor that accepts the configured base path - Deprecate runtime modification of the base path - Improve helper tests and cover uncovered paths - Introduce and wire up a factory for the helper that retrieves the base path from the expected config as per MVC docs Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Mar 24, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
froschdesign
reviewed
Apr 8, 2022
froschdesign
reviewed
Apr 8, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
LGTM! I will merge+release this after laminas/automatic-releases#210 is through.
Thanks @gsteel!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description