Gravatar Helper: Reinstates constants for images and ratings #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of this helper declared constants for default image types and ratings. They have been reinstated, adding ones that didn't exist. Tests have been updated to replace string literals with constants and also the expected strings are escaped to make the expected output easier to read. Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
changed the title
Ocramius
requested changes
Apr 6, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
gravatar-constants
branch
from
1809569 to
1f86f62
Compare
Ocramius
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of this helper declared constants for default image types and ratings. They have been reinstated, adding ones that didn't exist. Tests have been updated to replace string literals with constants and also the expected strings are escaped to make the expected output easier to read.
Closes #161
Relevant to #158