Clean up HeadStyle View Helper #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes laminas#6 It is not necessary to comment CSS within style tags so output has changed from: `<style><!-- a {} --></style>` to `<style> a {} </style>` The `<style media="">` attribute was restricted to list of pre-defined values such as `[screen, print, braille]`, when in reality the media attribute can contain any sort of media query such as `screen and (min-width: 10rem)`. These restrictions have been removed the property listing those restrictions deprecated. Additionally, if the `media` attribute is an array containing non-string values, an exception will be thrown. Previously, there would have been a type error. Style tag attributes not present in a list of 'allowed' attributes are silently ignored. This list has been updated to include the `nonce` attribute. Adds `@method setIndent` which magically proxies to the container. Adds probably desirable behaviour where if the user provides an empty string, i.e. `$this->headStyle()->appendStyle('');`, then no markup will be output for that item. Lots of type inference improvements and some test improvements. Signed-off-by: George Steel <george@net-glue.co.uk>
froschdesign
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
It is not necessary to comment CSS within style tags so output has changed from:
<style><!-- a {} --></style>to<style> a {} </style>The
<style media="">attribute was restricted to list of pre-defined values such as[screen, print, braille], when in reality the media attribute can contain any sort of media query such asscreen and (min-width: 10rem). These restrictions have been removed the property listing those restrictions deprecated.Additionally, if the
mediaattribute is an array containing non-string values, an exception will be thrown. Previously, there would have been a type error.Style tag attributes not present in a list of 'allowed' attributes are silently ignored. This list has been updated to include the
nonceattribute.Adds
@method setIndentwhich magically proxies to the container.Adds probably desirable behaviour where if the user provides an empty string, i.e.
$this->headStyle()->appendStyle('');, then no markup will be output for that item.Lots of type inference improvements and some test improvements.