Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes all outdated polyfills for related components, dropped PHP 7.3 support #95

Merged
merged 4 commits into from
Jan 8, 2022
Merged

Removes all outdated polyfills for related components, dropped PHP 7.3 support #95

merged 4 commits into from
Jan 8, 2022

Conversation

froschdesign
Copy link
Member

Q A
Enhancement yes

@froschdesign froschdesign added this to the 2.16.0 milestone Dec 17, 2021
Ocramius
Ocramius approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@froschdesign
Copy link
Member Author

froschdesign commented Dec 17, 2021 •
edited
Loading

@Ocramius
Version 7.3 of PHP is a problem – as to be expected.

@Ocramius
Copy link
Member

Let's drop it 🔥

@froschdesign
Copy link
Member Author

Uff, this component is still using laminas-coding-standard with version 1. 😩

@Ocramius Ocramius self-assigned this Dec 30, 2021
@Ocramius
Copy link
Member

@froschdesign I've rebased this, but won't be able to work on it today, so it will have to slide to 2.17.0

@Ocramius Ocramius removed this from the 2.16.0 milestone Dec 30, 2021
@Ocramius Ocramius changed the base branch from 2.16.x to 2.17.x January 8, 2022 16:15
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

A rebase is needed here

@Ocramius Ocramius added this to the 2.17.0 milestone Jan 8, 2022
@gsteel
Copy link
Member

gsteel commented Jan 8, 2022

Just tried dropping ^7 locally but we can't until laminas-console is removed (In 3.0?) it would appear.

@froschdesign @Ocramius
Removes all outdated polyfills for related components
4fa79ec 
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign @Ocramius
Updates versions of dependencies in Composer configuration
d9e9026 
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@froschdesign @Ocramius
Removes the support for version 7.3 of PHP
9c4f012 
Signed-off-by: Frank Brückner <dev@froschdesignstudio.de>
@Ocramius Ocramius changed the title Removes all outdated polyfills for related components Removes all outdated polyfills for related components, dropped PHP 7.3 support Jan 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

Rebased and adjusted baseline accordingly: 🚢

@Ocramius Ocramius merged commit 826d4d6 into laminas:2.17.x Jan 8, 2022
@Ocramius
Copy link
Member

Ocramius commented Jan 8, 2022

Thanks @froschdesign!

@github-actions github-actions bot mentioned this pull request Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@froschdesign @Ocramius @gsteel