Replace container-interop/container-interop with psr/container
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum version of laminas-servicemanager is 3.3 which in turn requires interop ^1.2 therefore this change should have no effect on consumers, but guarantees that we will have a Psr compatible container. Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
… version of psalm Signed-off-by: George Steel <george@net-glue.co.uk>
…the deprecated FactoryInterface Signed-off-by: George Steel <george@net-glue.co.uk>
…be simplified Signed-off-by: George Steel <george@net-glue.co.uk>
Also the creation context will very likely be decorated with a Psr Decorator which will cause the test to fail if so. The instance we're looking for is still there. Signed-off-by: George Steel <george@net-glue.co.uk>
…ger must accept a Psr Container Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
changed the title
Ocramius
requested changes
Dec 17, 2021
boesing
requested changes
Dec 20, 2021
Signed-off-by: George Steel <george@net-glue.co.uk>
…h ServiceManager Signed-off-by: George Steel <george@net-glue.co.uk>
…the baseline Signed-off-by: George Steel <george@net-glue.co.uk>
…ate baseline Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Dec 30, 2021
Ocramius
changed the title
container-interop/container-interop with psr/container
|
thanks @gsteel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With reference to this comment from @boesing, this pull removes all mention of Interop\Container
It doesn't appear that it is currently possible to have interop <1.2 installed due to SM >3.3 so the conflict in
composer.jsonis largely irrelevant.Because the lock file is updated, and newer version of psalm is installed, a number of non-trivial, new psalm errors emerged - I've added these initial errors to the baseline for now (A lot of them are due to the deprecated and to be removed flash messenger).
WRT to BC, although types have changed from
InteroptoPsr, it wouldn't have been possible for any type to not implement Psr prior to this patch would it?