Update to Laminas Coding Standard 2.3 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Steel <george@net-glue.co.uk>
…mportInternalFunction Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Dec 30, 2021
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Jan 8, 2022
| @@ -85,7 +83,7 @@ public function setFilterChain(FilterChain $filters) | |||
| public function getFilterChain() | |||
| { | |||
| if (null === $this->__filterChain) { | |||
| $this->setFilterChain(new FilterChain()); | |||
| $this->__filterChain = new FilterChain(); | |||
There was a problem hiding this comment.
Not much of a problem, but it may be possible that overrides to setFilterChain() make this change a potential issue.
I'll let this one roll though, as it's really an edge case.
| @@ -414,7 +429,7 @@ public function setFilterChain(FilterChain $filters) | |||
| public function getFilterChain() | |||
| { | |||
| if (null === $this->__filterChain) { | |||
| $this->setFilterChain(new FilterChain()); | |||
| $this->__filterChain = new FilterChain(); | |||
There was a problem hiding this comment.
Similar to above location: setter may have been overridden, although I'll let this one through.
Ocramius
changed the title
|
Thanks @gsteel! |
|
Yeah, but I was waiting while I was generating an almost 40Gb performance profile for an app: https://twitter.com/Ocramius/status/1479844147427172360 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating and cleaning up for Laminas Coding Standard 2.3 including WIP on reducing Psalm Errors.
I appreciate that reviewing this is going to be hellish… FWIW, I'm pretty confident that there are no BC breaks but I have fixed some obvious errors in doc blocks.
The most notable changes are likely adding nullable type hints such as
function Foo(Type $baz = null)changed tofunction Foo(?Type $baz = null).Also, there are a number of placeholder container/array access methods that had doc blocks for void return on methods such as
next()that were returningparent::next()- as these methods should have always been returning void anyhow, thereturnstatements have been dropped in these cases to satisfy CS.Please let me know if you'd like me to squash.
I also got a bit cavalier with the psalm baseline - I was left with around 130 new errors that all looked like the result of changing line numbers rather than new errors, so I just updated/added to the baseline - ~1000 psalm errors have been fixed in this pull so I decided to quit whilst I was ahead…