Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualified Cursor Support #25

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Qualified Cursor Support #25

merged 3 commits into from
Nov 6, 2019

Conversation

mpyw
Copy link
Member

@mpyw mpyw commented Nov 6, 2019

This PR makes it possible to use qualified cursor.

$tags = Tag::find(1)->posts()->withPivot('id')
    ->lampager()
    ->forward()->limit(3)
    ->orderBy('posts.id')
    ->seekable()
    ->paginate(['posts.id' => 2]);

@mpyw mpyw self-assigned this Nov 6, 2019
@mpyw mpyw requested a review from chitoku-k November 6, 2019 06:36
@coveralls
Copy link

coveralls commented Nov 6, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling c114838 on qualified-cursor into a063521 on master.

@chitoku-k
Copy link
Member

The implementation looks fine but more tests can be added!

@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
@lampager lampager deleted a comment from coveralls Nov 6, 2019
orderBy() and orderByDesc() don't support wrapped value.
Copy link
Member Author

@mpyw mpyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-LGTM

@chitoku-k
Copy link
Member

What is wrapped value mentioned in the commit message?

@mpyw
Copy link
Member Author

mpyw commented Nov 6, 2019

@chitoku-k

Wrapping means... alternatively "enclosed"

e.g.

  • id --(wrap)--> `id`
  • posts.id --(wrap)--> `posts`.`id`

orderBy() orderByDesc() can't accept already enclosed values.

Copy link
Member

@chitoku-k chitoku-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpyw mpyw merged commit 986b27b into master Nov 6, 2019
@mpyw mpyw deleted the qualified-cursor branch November 6, 2019 15:17
@mpyw mpyw changed the title Support qualified cursor Qualified Cursor Support Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants